linux-kernel - Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180305203533.GP8588@sirena.org.uk>
Date:   Mon, 5 Mar 2018 20:35:33 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Sasha Levin <Alexander.Levin@...rosoft.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jonas Gorski <jonas.gorski@...il.com>
Subject: Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem
 aware of message size limits

On Mon, Mar 05, 2018 at 08:07:46PM +0000, Sasha Levin wrote:
> On Mon, Mar 05, 2018 at 10:23:10AM +0000, Mark Brown wrote:
> >On Sat, Mar 03, 2018 at 10:27:56PM +0000, Sasha Levin wrote:

> >> The bcm63xx SPI controller does not allow manual control of the CS
> >> lines and will toggle it automatically before and after sending data,
> >> so we are limited to messages that fit in the FIFO buffer. Since the CS
> >> lines aren't available as GPIOs either, we will need to make slave
> >> drivers aware of this limitation so they can handle them accordingly.

> >This seems really aggressive for stable...

> Why so?

It's exposing more capability information but it's in the "how did this
ever work without the fix" range, and I'd worry that this might cause us
to do something like start exercising handling code in client drivers
that had never been tested.  Not that I can immediately see any client
drivers in mainline that actually pay attention...  :/

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)