linux-kernel - Re: [PATCH 1/4] module: Do not access sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc43ab0f-d1eb-df9c-8ebf-0c03ef5e2bc9@linux.alibaba.com>
Date:   Mon, 5 Mar 2018 13:32:10 +0800
From:   Jia Zhang <zhang.jia@...ux.alibaba.com>
To:     jeyu@...nel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] module: Do not access sig_enforce directly

Hi Jessica,

Could you review this patch series?

Thanks,
Jia

On 2018/3/1 下午5:09, Jia Zhang wrote:
> Call is_module_sig_enforced() instead.
> 
> Signed-off-by: Jia Zhang <zhang.jia@...ux.alibaba.com>
> ---
>  kernel/module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index ad2d420..003d0ab 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2789,7 +2789,7 @@ static int module_sig_check(struct load_info *info, int flags)
>  	}
>  
>  	/* Not having a signature is only an error if we're strict. */
> -	if (err == -ENOKEY && !sig_enforce)
> +	if (err == -ENOKEY && !is_module_sig_enforced())
>  		err = 0;
>  
>  	return err;
>