linux-kernel - Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Mar 2018 05:11:42 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Florent Flament <contact@...rentflament.com>
Cc:     kbuild-all@...org, andy.shevchenko@...il.com, jikos@...nel.org,
        benjamin.tissoires@...hat.com, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org,
        Florent Flament <contact@...rentflament.com>
Subject: Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech
 K290 USB keyboard

Hi Florent,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on hid/for-next]
[also build test ERROR on v4.16-rc4 next-20180305]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Florent-Flament/Logitech-K290-Add-driver-for-the-Logitech-K290-USB-keyboard/20180305-153311
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All errors (new ones prefixed by >>):

>> drivers/hid/hid-logitech-k290.c:92:3: error: 'struct hid_driver' has no member named 'resume'; did you mean 'remove'?
     .resume = k290_resume,
      ^~~~~~
      remove
>> drivers/hid/hid-logitech-k290.c:92:12: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .resume = k290_resume,
               ^~~~~~~~~~~
   drivers/hid/hid-logitech-k290.c:92:12: note: (near initialization for 'k290_driver.feature_mapping')
>> drivers/hid/hid-logitech-k290.c:93:3: error: 'struct hid_driver' has no member named 'reset_resume'
     .reset_resume = k290_resume,
      ^~~~~~~~~~~~
   drivers/hid/hid-logitech-k290.c:93:18: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .reset_resume = k290_resume,
                     ^~~~~~~~~~~
   drivers/hid/hid-logitech-k290.c:93:18: note: (near initialization for 'k290_driver.bus_add_driver')
   cc1: some warnings being treated as errors

vim +92 drivers/hid/hid-logitech-k290.c

    87	
    88	static struct hid_driver k290_driver = {
    89		.name = "hid-logitech-k290",
    90		.id_table = k290_devices,
    91		.input_configured = k290_input_configured,
  > 92		.resume = k290_resume,
  > 93		.reset_resume = k290_resume,
    94	};
    95	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (51495 bytes)