linux-kernel - Re: [PATCH v2 1/2] of: unittest: clean up changeset test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180305213910.olvnsprxw4rpjkzv@rob-hp-laptop>
Date:   Mon, 5 Mar 2018 15:39:10 -0600
From:   Rob Herring <robh@...nel.org>
To:     frowand.list@...il.com
Cc:     pantelis.antoniou@...sulko.com,
        Pantelis Antoniou <panto@...oniou-consulting.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        geert@...ux-m68k.org
Subject: Re: [PATCH v2 1/2] of: unittest: clean up changeset test

On Mon, Feb 26, 2018 at 02:01:22PM -0800, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...y.com>
> 
> In preparation for fixing __of_node_dup(), clean up the unittest
> function that calls it.
> 
> Devicetree nodes created from a flattened device tree have a name
> property.  Follow this convention for nodes added by a changeset.

I'd like to get rid of that property as it should be redundant, but 
that's somewhat orthogonal to this.

It also shouldn't be up to the caller to have to do this either, but 
that's already broken in the current API.

So I've applied these.

> 
> For node added by changeset, remove incorrect initialization of
> child node pointer.
> 
> Add an additional node pointer 'changeset' to more naturally reflect
> where in the tree the changeset is added.
> 
> Make changeset add property error messages unique.
> 
> Add whitespace to break apart logic blocks.
> 
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---