linux-kernel - Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data Integrity)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b241c894-7751-bd01-2658-4cb6b89f7454@oracle.com>
Date:   Mon, 5 Mar 2018 14:37:24 -0700
From:   Khalid Aziz <khalid.aziz@...cle.com>
To:     Dave Hansen <dave.hansen@...ux.intel.com>, davem@...emloft.net,
        akpm@...ux-foundation.org
Cc:     corbet@....net, bob.picco@...cle.com, steven.sistare@...cle.com,
        pasha.tatashin@...cle.com, mike.kravetz@...cle.com,
        rob.gardner@...cle.com, mingo@...nel.org, nitin.m.gupta@...cle.com,
        anthony.yznaga@...cle.com, kirill.shutemov@...ux.intel.com,
        tom.hromatka@...cle.com, allen.pais@...cle.com,
        tklauser@...tanz.ch, shannon.nelson@...cle.com,
        vijay.ac.kumar@...cle.com, mhocko@...e.com, jack@...e.cz,
        punit.agrawal@....com, hughd@...gle.com, thomas.tai@...cle.com,
        ross.zwisler@...ux.intel.com, dave.jiang@...el.com,
        willy@...radead.org, minchan@...nel.org,
        imbrenda@...ux.vnet.ibm.com, aarcange@...hat.com,
        kstewart@...uxfoundation.org, pombredanne@...b.com,
        tglx@...utronix.de, gregkh@...uxfoundation.org,
        nagarathnam.muthusamy@...cle.com, linux@...ck-us.net,
        jane.chu@...cle.com, dan.j.williams@...el.com, jglisse@...hat.com,
        ktkhai@...tuozzo.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        sparclinux@...r.kernel.org, Khalid Aziz <khalid@...ehiking.org>
Subject: Re: [PATCH v12 10/11] sparc64: Add support for ADI (Application Data
 Integrity)

On 03/05/2018 02:26 PM, Dave Hansen wrote:
> On 02/21/2018 09:15 AM, Khalid Aziz wrote:
>> +tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm,
>> +				    struct vm_area_struct *vma,
>> +				    unsigned long addr)
> ...
>> +	tags = kzalloc(size, GFP_NOWAIT|__GFP_NOWARN);
>> +	if (tags == NULL) {
>> +		tag_desc->tag_users = 0;
>> +		tag_desc = NULL;
>> +		goto out;
>> +	}
>> +	tag_desc->start = addr;
>> +	tag_desc->tags = tags;
>> +	tag_desc->end = end_addr;
>> +
>> +out:
>> +	spin_unlock_irqrestore(&mm->context.tag_lock, flags);
>> +	return tag_desc;
>> +}
> 
> OK, sorry, I missed this.  I do see that you now have per-ADI-block tag
> storage and it is not per-page.
> 
> How big can this storage get, btw?  Superficially it seems like it might
> be able to be gigantic for a large, sparse VMA.
> 

Tags are stored only for the pages being swapped out, not for the pages 
in entire vma. Each tag storage page can hold tags for 128 pages (each 
page has 128 4-bit tags, hence 64 bytes are needed to store tags for an 
entire page allowing each page to store tags for 128 pages). Sparse VMA 
does not cause any problems since holes do not have corresponding pages 
that will be swapped out. Tag storage pages are freed once all the pages 
they store tags for have been swapped back in, except for a small number 
of pages (maximum of 8) marked for emergency tag storage.

--
Khalid