linux-kernel - Re: [PATCH v2] scsi: ufs-qcom: add number of lanes for Tx and Rx links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180305220200.rah223rn4ndq7hd4@rob-hp-laptop>
Date:   Mon, 5 Mar 2018 16:02:00 -0600
From:   Rob Herring <robh@...nel.org>
To:     Can Guo <cang@...eaurora.org>
Cc:     subhashj@...eaurora.org, asutoshd@...eaurora.org,
        vivek.gautam@...eaurora.org, rnayak@...eaurora.org,
        vinholikatti@...il.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        Gilad Broner <gbroner@...eaurora.org>,
        Mark Rutland <mark.rutland@....com>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>,
        Yaniv Gardi <ygardi@...eaurora.org>,
        Sujit Reddy Thumma <sthumma@...eaurora.org>,
        Amit Nischal <anischal@...eaurora.org>,
        Maya Erez <merez@...eaurora.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs-qcom: add number of lanes for Tx and Rx
 links

On Tue, Feb 27, 2018 at 01:46:17PM +0800, Can Guo wrote:
> From: Gilad Broner <gbroner@...eaurora.org>
> 
> Different platforms may have different number of lanes for the UFS Tx/Rx
> links. Add parameter to device tree specifying how many lanes should be
> configured for the UFS Tx/Rx links. And don't print err message for clocks
> that are optional, this leads to unnecessary confusion about failure.
> 
> Signed-off-by: Gilad Broner <gbroner@...eaurora.org>
> Signed-off-by: Subhash Jadavani <subhashj@...eaurora.org>
> Signed-off-by: Can Guo <cang@...eaurora.org>
> ---
> 
> Changes since v1:
> 	- Change commit subject for better description.
> 	- Incorporated Rob's review comments to use lanes-tx and lanes-rx
> 	  to handle asymmetric Tx/Rx links.
> 
>  .../devicetree/bindings/ufs/ufshcd-pltfrm.txt      |  4 ++

Reviewed-by: Rob Herring <robh@...nel.org>

>  drivers/scsi/ufs/ufs-qcom.c                        | 65 +++++++++++++---------
>  drivers/scsi/ufs/ufshcd.c                          | 29 ++++++++++
>  drivers/scsi/ufs/ufshcd.h                          |  5 ++
>  4 files changed, 78 insertions(+), 25 deletions(-)