lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Mar 2018 07:01:21 +0100 From: Greg KH <gregkh@...uxfoundation.org> To: Arushi Singhal <arushisinghal19971997@...il.com> Cc: devel@...verdev.osuosl.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com Subject: Re: [PATCH v3] staging: ipx: Replace printk() with appropriate net_*macro_ratelimited() On Mon, Mar 05, 2018 at 09:47:40AM +0530, Arushi Singhal wrote: > Replace printk having a log level with the appropriate > net_*macro_ratelimited. > It's better to use actual device name as a prefix in error messages. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com> > --- > changes in v2 > *In v1 printk was changed to pr_*macro(), which is used > in kernel instead of calling printk() directly. And for drivers, > dev_*macro() or net_*macro_ratelimited() should be used for calling > printk() directly. > > changes in v3 > *Indentation is not changed, as line is exceeding 80 characters limit. > > drivers/staging/ipx/af_ipx.c | 2 +- Did you read drivers/staging/ipx/TODO? Please go do so. sorry, greg k-h
Powered by blists - more mailing lists