linux-kernel - Re: [PATCH 1/2] Documentation: dt: rng: add bindings doc for Keystone SA HWRNG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180306024038.uszf3r4nb4pw6kkf@rob-hp-laptop>
Date:   Mon, 5 Mar 2018 20:40:38 -0600
From:   Rob Herring <robh@...nel.org>
To:     Vitaly Andrianov <vitalya@...com>
Cc:     mpm@...enic.com, herbert@...dor.apana.org.au, arnd@...db.de,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, t-kristo@...com, m-karicheri2@...com
Subject: Re: [PATCH 1/2] Documentation: dt: rng: add bindings doc for
 Keystone SA HWRNG driver

On Thu, Mar 01, 2018 at 07:54:59AM -0500, Vitaly Andrianov wrote:
> The Keystone SA module has a hardware random generator module.
> This commit adds binding doc for the KS2 SA HWRNG driver.

Preferred subject prefix is "dt-bindings: rng: ..."

> 
> Signed-off-by: Vitaly Andrianov <vitalya@...com>
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
> ---
>  Documentation/devicetree/bindings/rng/ks-sa-rng.txt | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rng/ks-sa-rng.txt
> 
> diff --git a/Documentation/devicetree/bindings/rng/ks-sa-rng.txt b/Documentation/devicetree/bindings/rng/ks-sa-rng.txt
> new file mode 100644
> index 0000000..cc8ee44
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/ks-sa-rng.txt
> @@ -0,0 +1,21 @@
> +Keystone SoC Hardware Random Number Generator(HWRNG) Module
> +
> +On Keystone SoCs HWRNG module is a submodule of the Security Accelerator.
> +
> +- compatible: should be "ti,keystone-rng"
> +- ti,syscon-sa-cfg: phandle to syscon node of the SA configuration registers.
> +		    This registers are shared between hwrng and crypto drivers.
> +- clocks: phandle to the reference clocks for the subsystem
> +- clock-names: functional clock name. Should be set to "fck"
> +- reg: HWRNG module register space
> +
> +Example:
> +/* K2HK */
> +
> +hwrng@...4000 {

rng@...00

With those,

Reviewed-by: Rob Herring <robh@...nel.org>                                 

> +	compatible = "ti,keystone-rng";
> +	ti,syscon-sa-cfg = <&sa_config>;
> +	clocks = <&clksa>;
> +	clock-names = "fck";
> +	reg = <0x24000 0x1000>;
> +};
> -- 
> 2.7.4
>