linux-kernel - Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180306095320.2v63xokda4wsirwg@mwanda>
Date:   Tue, 6 Mar 2018 12:53:20 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Arushi Singhal <arushisinghal19971997@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        driverdevel <devel@...verdev.osuosl.org>,
        outreachy-kernel@...glegroups.com,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: irda: Replace printk() with appropriate
 net_*macro_ratelimited()

On Mon, Mar 05, 2018 at 11:41:43PM +0530, Arushi Singhal wrote:
> On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter <dan.carpenter@...cle.com>
> wrote:
> 
> > On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote:
> > > Replace printk having a log level with the appropriate
> > > net_*macro_ratelimited.
> > > It's better to use actual device name as a prefix in error messages.
> > > Indentation is also changed, to fix the  checkpatch issue if line is not
> > > exceding 80 characters.
> > >
> > > Signed-off-by: Arushi Singhal <arushisinghal19971997@...il.com>
> > > ---
> > >  .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c      | 22
> > +++++++++++-----------
> > >  1 file changed, 11 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
> > b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
> > > index e6648f7..200fe5f 100644
> > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
> > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
> > > @@ -73,7 +73,7 @@ static void *ieee80211_ccmp_init(int key_idx)
> > >
> > >       priv->tfm = (void *)crypto_alloc_cipher("aes", 0,
> > CRYPTO_ALG_ASYNC);
> > >       if (IS_ERR(priv->tfm)) {
> > > -             printk(KERN_DEBUG "ieee80211_crypt_ccmp: could not
> > allocate crypto API aes\n");
> > > +             net_dbg_ratelimited("ieee80211_crypt_ccmp: could not
> > allocate crypto API aes\n");
> >
> >
> > This should probably just be deleted.
> >
> Hello Dan
> Why we should make this change?
> According to me it's use here to print debug message.
> Wanted to know more about your thought on this.

Actually, I looked at this wrong.  I though that crypto_alloc_cipher()
had its own error messages.  Sorry about that.

regards,
dan carpenter