linux-kernel - Re: [PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal abort task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3983d075-af2e-5c69-2708-51db8a6b79cb@suse.de>
Date:   Tue, 6 Mar 2018 12:23:01 +0100
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, robh+dt@...nel.org,
        mark.rutland@....com
Cc:     linux-scsi@...r.kernel.org, devicetree@...r.kernel.org,
        linuxarm@...wei.com, linux-kernel@...r.kernel.org,
        Xiaofei Tan <tanxiaofei@...wei.com>
Subject: Re: [PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal
 abort task

On 03/05/2018 03:48 PM, John Garry wrote:
> From: Xiaofei Tan <tanxiaofei@...wei.com>
> 
> The current 110ms expiry time is not long enough for the internal
> abort task.
> 
> The reason is that the internal abort task could be blocked in HW
> if the HW is retrying to set up link. The internal abort task will
> be executed only when the retry process finished.
> 
Hmm. That sounds weird.
I would have expected that a link retrain will force a device reset,
after which no tasks should be active on the target.
Consequently the succeeding abort task will be a no-op.
Care to clarify?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)