linux-kernel - Re: [PATCH] dmaengine: pl330: fix a race condition in case of threaded irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180306115153.GS15443@localhost>
Date:   Tue, 6 Mar 2018 17:21:54 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Qi Hou <qi.hou@...driver.com>
Cc:     dan.j.williams@...el.com, fmh6jj@...il.com,
        fmhess@...rs.sourceforge.net, jassisinghbrar@...il.com,
        rmk+kernel@....linux.org.uk, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: fix a race condition in case of
 threaded irqs

On Tue, Mar 06, 2018 at 09:13:37AM +0800, Qi Hou wrote:
> When booting up with "threadirqs" in command line, all irq handlers of the DMA
> controller pl330 will be threaded forcedly. These threads will race for the same
> list, pl330->req_done.
> 
> Before the callback, the spinlock was released. And after it, the spinlock was
> taken. This opened an race window where another threaded irq handler could steal
> the spinlock and be permitted to delete entries of the list, pl330->req_done.
> 
> If the later deleted an entry that was still referred to by the former, there would
> be a kernel panic when the former was scheduled and tried to get the next sibling
> of the deleted entry.

Applied, thanks

-- 
~Vinod