linux-kernel - Re: [PATCH] perf report: Provide libtraceevent with a kernel symbol resolver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180306140117.GB10176@kernel.org>
Date:   Tue, 6 Mar 2018 11:01:17 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wang YanQing <udknight@...il.com>, jolsa@...hat.com,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf report: Provide libtraceevent with a kernel symbol
 resolver

Em Tue, Mar 06, 2018 at 03:36:58PM +0800, Wang YanQing escreveu:
> On Thu, Feb 08, 2018 at 01:20:31PM +0100, Jiri Olsa wrote:
> > On Mon, Jan 15, 2018 at 12:47:32PM +0800, Wang YanQing wrote:
> > > So that beautifiers wanting to resolve kernel function addresses to
> > > names can do its work, and when we use "perf report" for output of
> > > "perf kmem record", we will get kernel symbol output.
> > > 
> > > Signed-off-by: Wang YanQing <udknight@...il.com>
> > 
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> Hi! Arnaldo Carvalho de Melo
> 
> What is the status of this patch now?
> Does the patch sanked to the bottom of your mailbox?

It looks ok, but you forgot to add a before and after output of tools
affected by the patch.

Reading the patch one can try and figure out how to test your patch, but
if you show how the output is changed, providing the exact command line
used to produce the output, then you will make it easier for reviewers
to reproduce your results, testing your patch.

I try to do this for every patch, so it all adds up, please help me with
reviewing your patch :-)

- Arnaldo