linux-kernel - Re: [PATCH v2 2/2] dt-bindings: input: Add binding for RAVE SP input driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5DTWrMS-RrDwqMg5CTjH_dCdkiyvDJ+zgje49yzbbNUhg@mail.gmail.com>
Date:   Tue, 6 Mar 2018 11:17:21 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Guenter Roeck <linux@...ck-us.net>,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>
Subject: Re: [PATCH v2 2/2] dt-bindings: input: Add binding for RAVE SP input driver

Hi Andrey,

On Thu, Mar 1, 2018 at 1:55 PM, Andrey Smirnov <andrew.smirnov@...il.com> wrote:
l
> +++ b/Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.txt
> @@ -0,0 +1,24 @@
> +Zodiac Inflight Innovations RAVE Supervisory Processor Power Button Bindings
> +
> +RAVE SP input device is a "MFD cell" device corresponding to power
> +button functionality of RAVE Supervisory Processor. It is expected
> +that its Device Tree node is specified as a child of the node
> +corresponding to the parent RAVE SP device (as documented in
> +Documentation/devicetree/bindings/mfd/zii,rave-sp.txt)
> +
> +Required properties:
> +
> +- compatible: Should be "zii,rave-sp-pwrbutton"
> +
> +Example:
> +
> +       rave-sp {
> +               compatible = "zii,rave-sp-rdu1";
> +               current-speed = <38400>;
> +
> +               pwrbutton {
> +                       compatible = "zii,rave-sp-pwrbutton";
> +                       status = "okay";

In the dts patch review Shawn said:

"The okay status is to flip the state of devices that are initially
disabled.  I think it's unnecessary for the case here."

so please remove the status line.