linux-kernel - Re: [RFC 3/4] MIPS: Ingenic: Initial X1000 SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180306000832.GL4197@saruman>
Date:   Tue, 6 Mar 2018 00:08:32 +0000
From:   James Hogan <jhogan@...nel.org>
To:     PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, ralf@...ux-mips.org,
        mturquette@...libre.com, sboyd@...eaurora.org,
        devicetree@...r.kernel.org, linux-mips@...ux-mips.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        paul@...pouillou.net, malat@...ian.org, dom.peklo@...il.com
Subject: Re: [RFC 3/4] MIPS: Ingenic: Initial X1000 SoC support

On Wed, Sep 27, 2017 at 08:45:26PM +0530, PrasannaKumar Muralidharan wrote:
> Add initial Ingenic X1000 SoC support. Provide minimum necessary
> information to boot kernel to an initramfs userspace.
> 
> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
> ---
>  arch/mips/boot/dts/ingenic/x1000.dtsi | 93 +++++++++++++++++++++++++++++++++++
>  arch/mips/jz4740/Kconfig              |  6 +++
>  arch/mips/jz4740/time.c               |  2 +-
>  3 files changed, 100 insertions(+), 1 deletion(-)
>  create mode 100644 arch/mips/boot/dts/ingenic/x1000.dtsi

arch/mips/jz4780/setup.c, specifically get_board_mach_type() and
get_system_type() will need updating too.

Does X1000 use a different PRID, or is it basically just a JZ4780 core
with different SoC peripherals?

> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
> new file mode 100644
> index 0000000..abbb9ec
> --- /dev/null
> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> @@ -0,0 +1,93 @@
> +/*
> + * Copyright (C) 2016 PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.

(these will need updating to use SPDX identifiers if you respin)

> +	cgu: jz4780-cgu@...00000 {

not sure jz4780 is appropriate here.

> +		compatible = "ingenic,x1000-cgu";
> +		reg = <0x10000000 0x100>;
> +
> +		clocks = <&ext>, <&rtc>;
> +		clock-names = "ext", "rtc";
> +
> +		#clock-cells = <1>;
> +	};

Cheers
James

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)