linux-kernel - Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5A9EAC92.4050702@rock-chips.com>
Date:   Tue, 06 Mar 2018 22:58:26 +0800
From:   JeffyChen <jeffy.chen@...k-chips.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        linux-kernel@...r.kernel.org
CC:     Arnd Bergmann <arnd@...db.de>, Lee Jones <lee.jones@...aro.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

+CC Mark.

even this is already fixed by a430ab205d29 ("regmap: debugfs: 
Disambiguate dummy debugfs file name")

but maybe we can still have this for a better debugfs name?

On 03/06/2018 07:04 PM, Jeffy Chen wrote:
> We are now allowing to register debugfs for syscon regmap, and not
> having a valid name will end up using "dummy" to create debugfs dir.
>
> Fixes: 9b947a13e7f6 ("regmap: use debugfs even when no device")
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> ---
>
>   drivers/mfd/syscon.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 7eaa40bc703f..250d22f40c84 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -109,6 +109,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
>   	syscon_config.reg_stride = reg_io_width;
>   	syscon_config.val_bits = reg_io_width * 8;
>   	syscon_config.max_register = resource_size(&res) - reg_io_width;
> +	syscon_config.name = of_node_full_name(np);
>
>   	regmap = regmap_init_mmio(NULL, base, &syscon_config);
>   	if (IS_ERR(regmap)) {
>