linux-kernel - RE: [PATCH 0/5 V2] tpm: timeouts revamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422F491@hasmsx108.ger.corp.intel.com>
Date:   Tue, 6 Mar 2018 15:05:44 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        "Javier Martinez Canillas" <javierm@...hat.com>
CC:     Jason Gunthorpe <jgg@...pe.ca>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/5 V2] tpm: timeouts revamp

 
> On Tue, Mar 06, 2018 at 01:39:49PM +0100, Javier Martinez Canillas wrote:
> > On 03/06/2018 01:17 PM, Jarkko Sakkinen wrote:
> > > On Tue, 2018-03-06 at 11:24 +0200, Tomas Winkler wrote:
> > >> This series cleans up tpm timeouts setting and handling.
> > >>
> > >> First motivation was to fix failures coming from too short timeouts
> > >> for commands that creates keys.
> > >> Key generation may take significant time depending on the
> > >> underlying hardware. Rather than increasing default timeout a new
> > >> constant is added, to not stall too long on regular commands failures.
> > >>
> > >> Second is to define timeouts for new tpm2 commands defined in TCG
> > >> 1.36 spec.
> > >
> >
> > Probably a typo, since the latest TCG spec version is the 1.38 [0].
> >
> > > Where can we get that specification? I don't have that new version
> > > and couldn't find it from the public internet.
> > >
> > > /Jarkko
> > >
> >
> > [0]: https://trustedcomputinggroup.org/tpm-library-specification/
> 
> I already have that version of the specifications but I thought that we were
> speaking about PC Client Platform spefication, which is at version 1.30. TCG
> spec is an ambiguous term so that is where the confusion started from.
> 
TCG spec doesn't define timeouts just new commands 

> The only spec I've seen some timeouts is the PC Client Specification but I
> guess I've then missed the list in TPM 2.0 spefication. Where are they listed?
> I worked with Will Arthur durations based on PC Client Specification when
> TPM 2.0 support was first implemented.


That's correct, this  PTP spec. It defines the timeouts for the commands, this is stated in the patch comments.

Need to cross reference these two specs. 

Thanks
Tomas