linux-kernel - Re: [PATCH v16 0/9] LPC: legacy ISA I/O support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ef757ff-8430-017f-59d3-ff67f49f5a80@huawei.com>
Date:   Tue, 6 Mar 2018 16:22:36 +0000
From:   John Garry <john.garry@...wei.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
CC:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "Hanjun Guo" <hanjun.guo@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Arnd Bergmann <arnd@...db.de>,
        Mark Rutland <mark.rutland@....com>,
        Olof Johansson <olof@...om.net>,
        Dann Frazier <dann.frazier@...onical.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Rob Herring <robh@...nel.org>, Joe Perches <joe@...ches.com>,
        "Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>, Corey Minyard <minyard@....org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Frank Rowand <frowand.list@...il.com>,
        Alexander Graf <agraf@...e.de>
Subject: Re: [PATCH v16 0/9] LPC: legacy ISA I/O support

>>>>
>>>> Based on this patch-set, all the I/O accesses to Hip06/Hip07 LPC
>>>> peripherals can
>>>> be supported without any changes on the existing ipmi-si driver.
>>>>
>>>> The whole patchset has been tested on Hip07 D05 board both using DTB
>>>> and ACPI.
>>>>
>>>
>>>> V15 thread here: https://lkml.org/lkml/2018/2/26/584
>>>
>>>
>>> Thanks for an update.
>>> Though I answered to previous thread.
>>>
>>> Summary: I'm fine with the series as long as maintainers are fine
>>> (Rafael et al.). On personal side I think that the handler approach is
>>> better. Details are in v15 thread.
>>
>>
>> Hi Andy,
>>
>> Thanks for your input and continued support. As I mentioned in reply in v15,
>> the handler support would (or has) faced issues. And Rafael seems fine with
>> deferring the probe to the LLDD in Patch #7/9
>

Hi Rafael,

> Well, the only sort-of concern is that these devices may not be
> "serial bus slaves" in general, so the naming is slightly confusing.
>

Right, the name.

The key point is that we model the bus the same as other serial buses 
like I2C or SPI, so require the same treatment from the ACPI scan.

Would you prefer acpi_is_serial_bus_slave() and 
acpi_device_flags.serial_bus_slave symbols be modified also?

> But overall this approach and the one based on a scan handler both
> boil down to checking a (list of) device ID(s) and doing something
> special in case of a match.
>
> .
>

Thanks,
John