lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Mar 2018 09:55:13 -0700 From: Logan Gunthorpe <logang@...tatee.com> To: Oliver O'Halloran <oohall@...il.com>, linux-kernel@...r.kernel.org Cc: linux-nvdimm@...ts.01.org, Christoph Hellwig <hch@....de>, Dan Williams <dan.j.williams@...el.com> Subject: Re: [PATCH] kernel/memremap: Remove stale devres_free() call On 05/03/18 09:56 PM, Oliver O'Halloran wrote: > devm_memremap_pages() was re-worked in e8d513483300 to take a caller > allocated struct dev_pagemap as a function parameter. A call to > devres_free() was left in the error cleanup path which results in > a kernel panic if the remap fails for some reason. Remove it > to fix the panic and let devm_memremap_pages() fail gracefully. > > Fixes: e8d513483300 ("memremap: change devm_memremap_pages interface to use struct dev_pagemap") > Cc: Logan Gunthorpe <logang@...tatee.com> > Cc: Christoph Hellwig <hch@....de> > Cc: Dan Williams <dan.j.williams@...el.com> > Signed-off-by: Oliver O'Halloran <oohall@...il.com> Reviewed-by: Logan Gunthorpe <logang@...tatee.com> > --- > Both in-tree users of devm_memremap_pages() embed dev_pagemap into other > structures so this shouldn't cause any leaks. Logan's p2p series does > add one usage that assumes pgmap will be freed on error so that'll > need fixing. Yup, nice catch! I'll fix that for the next series. Thanks, Logan
Powered by blists - more mailing lists