linux-kernel - Re: [PATCH] perf stat: fix cvs output format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180306170011.GD25017@tassilo.jf.intel.com>
Date:   Tue, 6 Mar 2018 09:00:11 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...hat.com>, Ilya Pronin <ipronin@...tter.com>
Subject: Re: [PATCH] perf stat: fix cvs output format

On Mon, Mar 05, 2018 at 10:43:53PM -0800, Cong Wang wrote:
> From: Ilya Pronin <ipronin@...tter.com>
> 
> When printing stats in CSV mode, perf stat appends extra CSV
> separators when counter is not supported:
> 
> <not supported>,,L1-dcache-store-misses,mesos/bd442f34-2b4a-47df-b966-9b281f9f56fc,0,100.00,,,,
> 
> which causes a failure of parsing fields. The numbers of separators

Causes failure in what?

> is fixed for each line, no matter supported or not supported.

I don't think they're extra fields, there are cases where they can be filled out
for variance, metricvalue, unit. And other code in perf too uses empty
fields when something is not available.

        - optional usec time stamp in fractions of second (with -I xxx)
        - optional CPU, core, or socket identifier
        - optional number of logical CPUs aggregated
        - counter value
        - unit of the counter value or empty
        - event name
        - run time of counter
        - percentage of measurement time the counter was running
        - optional variance if multiple values are collected with -r  
        - optional metric value
        - optional unit of metric


-Andi