linux-kernel - Re: [PATCH] acpi, nfit: remove redundant __func__ in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180306005548.GB15227@linux.intel.com>
Date:   Mon, 5 Mar 2018 17:55:48 -0700
From:   Ross Zwisler <ross.zwisler@...ux.intel.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NV-DIMM Mailing List <linux-nvdimm@...ts.01.org>
Subject: Re: [PATCH] acpi, nfit: remove redundant __func__ in dev_dbg

On Fri, Mar 02, 2018 at 01:20:49PM +0100, Johannes Thumshirn wrote:
> Dynamic debug can be instructed to add the function name to the debug
> output using the +f switch, so there is no need for the nfit module to
> do it again. If a user decides to add the +f switch for nfit's dynamic
> debug this results in double prints of the function name like the
> following:
> 
> [ 2391.935383] acpi_nfit_ctl: nfit ACPI0012:00: acpi_nfit_ctl:nmem8 cmd: 10: func: 1 input length: 0
> 
> Thus remove the stray __func__ printing.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>

I looked through this and this all looked right to me.

Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com>