linux-kernel - Re: [PATCH 3/3] staging:iio:meter: Aligns open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180306202138.dquhxpfiwq6matbe@smtp.gmail.com>
Date:   Tue, 6 Mar 2018 17:21:38 -0300
From:   Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        daniel.baluta@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] staging:iio:meter: Aligns open parenthesis

Hi

On 03/06, Dan Carpenter wrote:
> On Tue, Mar 06, 2018 at 09:26:07AM -0300, Rodrigo Siqueira wrote:
> > @@ -63,7 +63,7 @@ int ade7758_probe_trigger(struct iio_dev *indio_dev)
> >  	int ret;
> >  
> >  	st->trig = iio_trigger_alloc("%s-dev%d",
> > -					spi_get_device_id(st->us)->name,
> > +				     spi_get_device_id(st->us)->name,
> >  					indio_dev->id);
>                                         ^^^^^^^^^^^^^
> The "indio_dev->id" needs to be aligned as well.

I will fix it and send a v2.

Thanks for the review!
 
> >  	if (!st->trig) {
> >  		ret = -ENOMEM;
> 
> regards,
> dan carpenter
>