linux-kernel - Re: [PATCH] parisc: time: stop validating rtc_time in .read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Mar 2018 22:20:26 +0100
From:   Helge Deller <deller@....de>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     "James E . J . Bottomley" <jejb@...isc-linux.org>,
        linux-parisc@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: time: stop validating rtc_time in .read_time

On 21.02.2018 22:40, Alexandre Belloni wrote:
> The RTC core is always calling rtc_valid_tm after the read_time callback.
> It is not necessary to call it just before returning from the callback.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Acked-by: Helge Deller <deller@....de>

Thanks!
Helge


> ---
>  arch/parisc/kernel/time.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
> index 4b8fd6dc22da..f2890bd240f8 100644
> --- a/arch/parisc/kernel/time.c
> +++ b/arch/parisc/kernel/time.c
> @@ -173,7 +173,7 @@ static int rtc_generic_get_time(struct device *dev, struct rtc_time *tm)
>  
>  	/* we treat tod_sec as unsigned, so this can work until year 2106 */
>  	rtc_time64_to_tm(tod_data.tod_sec, tm);
> -	return rtc_valid_tm(tm);
> +	return 0;
>  }
>  
>  static int rtc_generic_set_time(struct device *dev, struct rtc_time *tm)
>