linux-kernel - Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKZd0CdJKshm1F_qdW0F5TwtdeGSw6wST6NsfWchEzBiw@mail.gmail.com>
Date:   Wed, 7 Mar 2018 14:17:15 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:     wangnan0 <wangnan0@...wei.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

On Tue, Mar 6, 2018 at 8:12 PM, Ravi Bangoria
<ravi.bangoria@...ux.vnet.ibm.com> wrote:
>
>
> On 03/07/2018 03:34 AM, Kees Cook wrote:
>> On Tue, Mar 6, 2018 at 12:12 AM, Ravi Bangoria
>> <ravi.bangoria@...ux.vnet.ibm.com> wrote:
>>>
>>> On 02/08/2018 09:13 AM, Ravi Bangoria wrote:
>>>> Wang, ping :)
>>>>
>>>> Kees, I don't hear back from Wang and no one has reported any issues with
>>>> the patches yet. Can I have your Acked-by?
>> I didn't see a v2 of these patches with the output fixed?
>
> Kees, I didn't send v2 because those 0s seems unnecessary to me.

Oh, okay. I don't care either way. That's up to whoever consumes that
output. Usually it's bad form to change formatting for a userspace
API, but if nothing cares, then sure. :)

> Please let me know if you still wants to show them. Will re-spin :)

AIUI, it's "safer" to include them since that's what it did before.

-Kees

>
> Thanks,
> Ravi
>
> PS: Changing Masami's email address in cc.
>



-- 
Kees Cook
Pixel Security