linux-kernel - Re: [PATCH] kernel/sys_ni: sort cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180307082612.tveaovxhhtvyu5dj@gmail.com>
Date:   Wed, 7 Mar 2018 09:26:12 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Dominik Brodowski <linux@...inikbrodowski.net>
Cc:     linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        torvalds@...ux-foundation.org, luto@...capital.net,
        tglx@...utronix.de, viro@...iv.linux.org.uk, ak@...ux.intel.com,
        x86@...nel.org
Subject: Re: [PATCH] kernel/sys_ni: sort cond_syscall() entries


* Dominik Brodowski <linux@...inikbrodowski.net> wrote:

> Shuffle the cond_syscall() entries in kernel/sys_ni.c around so that they
> are kept in the same order as in include/uapi/asm-generic/unistd.h. For
> better structuring, add the same comments as in that file, but keep a few
> additional comments and extend the commentary where it seems useful.
> 
> Signed-off-by: Dominik Brodowski <linux@...inikbrodowski.net>
> 
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index b5189762d275..44c65e4d2528 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -17,245 +17,403 @@ asmlinkage long sys_ni_syscall(void)
>  	return -ENOSYS;
>  }
>  
> -cond_syscall(sys_quotactl);
> -cond_syscall(sys32_quotactl);
> -cond_syscall(sys_acct);
> +/*
> + * This list is kept in the same order as include/uapi/asm-generic/unistd.h.
> + * Architecture specific entries go below, then follow deprecated or obsolote
> + * system calls.

That's both a typo and wrong: 'follow' in this context means the exact opposite 
ordering.

I think this is more accurate:

    * Architecture specific entries go below, followed by deprecated or obsolete
    * system calls.

Thanks,

	Ingo