linux-kernel - Re: [PATCH] slimbus: core: use put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55c2399e-3136-4a90-26ac-0ebcb2918a15@linaro.org>
Date:   Wed, 7 Mar 2018 10:45:50 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, broonie@...nel.org,
        gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH] slimbus: core: use put_device() instead of kfree()



On 07/03/18 10:22, Arvind Yadav wrote:
> Never directly free @dev after calling device_register(), even
> if it returned an error! Always use put_device() to give up the
> reference initialized.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>   drivers/slimbus/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
Looks good for me,

Will queue it up.

> diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
> index 4988a8f..7ddfc67 100644
> --- a/drivers/slimbus/core.c
> +++ b/drivers/slimbus/core.c
> @@ -141,7 +141,7 @@ static struct slim_device *slim_alloc_device(struct slim_controller *ctrl,
>   	sbdev->e_addr = *eaddr;
>   	ret = slim_add_device(ctrl, sbdev, node);
>   	if (ret) {
> -		kfree(sbdev);
> +		put_device(&sbdev->dev);
>   		return NULL;
>   	}
>   
> 

thanks,
srini