linux-kernel - Re: Regression in IPMI on 4.15.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11417cb3-7302-26b1-5bcb-e790b1ee8cf4@acm.org>
Date:   Tue, 6 Mar 2018 19:53:30 -0600
From:   Corey Minyard <minyard@....org>
To:     Laura Abbott <labbott@...hat.com>
Cc:     openipmi-developer@...ts.sourceforge.net,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Regression in IPMI on 4.15.6

On 03/06/2018 05:54 PM, Laura Abbott wrote:
> On 03/06/2018 09:19 AM, Corey Minyard wrote:
>> On 03/06/2018 11:17 AM, Laura Abbott wrote:
>>> On 03/05/2018 11:39 AM, Corey Minyard wrote:
>>>> On 03/05/2018 01:31 PM, Corey Minyard wrote:
>>>>> On 03/05/2018 01:07 PM, Laura Abbott wrote:
>>>>>> On 03/02/2018 05:46 AM, Corey Minyard wrote:
>>>>>>> On 02/28/2018 01:07 PM, Corey Minyard wrote:
>>>>>>>> On 02/28/2018 08:17 AM, Corey Minyard wrote:
>>>>>>>>> On 02/28/2018 07:53 AM, Corey Minyard wrote:
>>>>>>>>>> On 02/27/2018 05:55 PM, Laura Abbott wrote:
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Fedora got a bug report of a crash in IPMI on 4.15.6
>>>>>>>>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1549316
>>>>>>>>>>> Unfortunately, it's only a screenshot but it's fairly
>>>>>>>>>>> clear. It looks like a panic in the error handling path
>>>>>>>>>>> in platform_device_unregister. Any ideas?
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> You may also run into another issue.  You can pull the
>>>>>>>>> individual patch at
>>>>>>>>>
>>>>>>>>> https://github.com/cminyard/linux-ipmi.git 
>>>>>>>>> c8a1972e77dbe321ce5ce0247056e727234cbaec
>>>>>>>>
>>>>>>>> Actually, it needed a few more tweaks.  Can you do change
>>>>>>>> 426fa6179dae677134dfb37b21d057819418515b
>>>>>>>> instead?  It's "ipmi: Fix some error cleanup issues"
>>>>>>>>
>>>>>>>> I can send you patches, if you like.  If you could test and get 
>>>>>>>> back
>>>>>>>> to me, that would be great.
>>>>>>>
>>>>>>> Laura, have you had a chance to test this?  I'd like to get it 
>>>>>>> in soon,
>>>>>>> if possible.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> -corey
>>>>>>>
>>>>>>
>>>>>> I think "ipmi: Re-use existing macros for built-in properties" is 
>>>>>> broken:
>>>>>>
>>>>>
>>>>> That particular requires some new stuff.  I was just wanting you 
>>>>> to pull that individual patch,
>>>>> not the whole branch.  I can just send the two patches, if you like.
>>>>
>>>> Or, I just pulled in 4.15.6 and cherry picked those two patches to:
>>>>
>>>> https://github.com/cminyard/linux-ipmi.git fix-pdev-unreg
>>>>
>>>> Hopefully that makes things easier.
>>>>
>>>> -corey
>>>>
>>>
>>> Yes, the reporter said it worked fine.
>>>
>>
>> It would be helpful to me to have a "Tested-by" line.  Can I put one in?
>> If so, whose name/email do I use?
>>
>> Thanks for testing.
>>
>> -corey
>
>
> You can use the reporter and tester:
>
> Tested-by: Bill Perkins <wmp@...wood.net>
>
Thanks a bunch, Laura.  I have it queued for 4.17, and
backport to 4.15 and 4.16.  If you need it sooner, I can
send it to Linus now.

-corey