linux-kernel - Re: [Outreachy kernel] Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180307110159.gnetxajp4c7oz52x@mwanda>
Date:   Wed, 7 Mar 2018 14:01:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Arushi Singhal <arushisinghal19971997@...il.com>,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        outreachy-kernel@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] Re: [PATCH v3] staging: rtl8192u: Replace
 printk() with more standardize output format.

On Wed, Mar 07, 2018 at 11:52:16AM +0100, Julia Lawall wrote:
> 
> 
> On Wed, 7 Mar 2018, Dan Carpenter wrote:
> 
> > On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote:
> > > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
> > >  	keyidx = pos[3];
> > >  	if (!(keyidx & (1 << 5))) {
> > >  		if (net_ratelimit()) {
> > > -			printk(KERN_DEBUG "CCMP: received packet without ExtIV flag from %pM\n",
> > > -				hdr->addr2);
> > > +			netdev_dbg(skb->dev, "CCMP: received packet without ExtIV flag from %pM\n",
> > > +				   hdr->addr2);
> > >  		}
> >
> > I'm sorry.  I really hate to do this to you...  But the right thing here
> > is to use net_dbg_ratelimited() but get rid of the if (net_ratelimit())
> > check.  So it looks like this:
> >
> > 	if (!(keyidx & (1 << 5))) {
> > 		net_dbg_ratelimited(skb->dev,
> > 				    "CCMP: received packet without ExtIV flag from %pM\n",
> > 				    hdr->addr2);
> > 	}
> >
> > Sorry again, when I looked at it before I just replied what my fast
> > thinking lizard brain said instead of taking time to look at what I was
> > saying.
> 
> I don't think that net_dbg_ratelimited wants a skb->dev argument.  The
> various definitions in include/linux/net.h just have fmt as the first
> argument.
>

Ah....  That's fine then.  Don't worry about it.

regards,
dan carpenter