linux-kernel - [PATCH 2/2] sh: superhyway: use put_device() if device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ea06f4581b63ebdbb7c9e8739780181f53a9c774.1520420267.git.arvind.yadav.cs@gmail.com>
Date:   Wed,  7 Mar 2018 16:33:14 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     ysato@...rs.sourceforge.jp, dalias@...c.org
Cc:     linux-kernel@...r.kernel.org, linux-sh@...r.kernel.org
Subject: [PATCH 2/2] sh: superhyway: use put_device() if device_register fail

if device_register() returned an error! Always use put_device()
to give up the reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/sh/superhyway/superhyway.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/sh/superhyway/superhyway.c b/drivers/sh/superhyway/superhyway.c
index 348836b..98922e7 100644
--- a/drivers/sh/superhyway/superhyway.c
+++ b/drivers/sh/superhyway/superhyway.c
@@ -54,6 +54,7 @@ int superhyway_add_device(unsigned long base, struct superhyway_device *sdev,
 			  struct superhyway_bus *bus)
 {
 	struct superhyway_device *dev = sdev;
+	int ret;
 
 	if (!dev) {
 		dev = kzalloc(sizeof(struct superhyway_device), GFP_KERNEL);
@@ -87,7 +88,11 @@ int superhyway_add_device(unsigned long base, struct superhyway_device *sdev,
 
 	superhyway_devices++;
 
-	return device_register(&dev->dev);
+	ret = device_register(&dev->dev);
+	if (ret)
+		put_device(&dev->dev);
+
+	return ret;
 }
 
 int superhyway_add_devices(struct superhyway_bus *bus,
@@ -110,8 +115,10 @@ static int __init superhyway_init(void)
 	int ret;
 
 	ret = device_register(&superhyway_bus_device);
-	if (unlikely(ret))
+	if (unlikely(ret)) {
+		put_device(&superhyway_bus_device);
 		return ret;
+	}
 
 	for (bus = superhyway_channels; bus->ops; bus++)
 		ret |= superhyway_scan_bus(bus);
-- 
1.9.1