linux-kernel - Re: [PATCH net] xfrm: Verify MAC header exists before overwriting eth_hdr(skb)->h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180307125708.rb55ny6rhxqgstpy@gauss3.secunet.de>
Date:   Wed, 7 Mar 2018 13:57:08 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <yossiku@...lanox.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        "Hideaki YOSHIFUJI" <yoshfuji@...ux-ipv6.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Artem Savkov <artem.savkov@...il.com>
Subject: Re: [PATCH net] xfrm: Verify MAC header exists before overwriting
 eth_hdr(skb)->h_proto

On Sun, Mar 04, 2018 at 09:03:52PM +0200, yossiku@...lanox.com wrote:
> From: Yossi Kuperman <yossiku@...lanox.com>
> 
> Artem Savkov reported that commit 5efec5c655dd leads to a packet loss under
> IPSec configuration. It appears that his setup consists of a TUN device,
> which does not have a MAC header.
> 
> Make sure MAC header exists.
> 
> Note: TUN device sets a MAC header pointer, although it does not have one.
> 
> Fixes: 5efec5c655dd ("xfrm: Fix eth_hdr(skb)->h_proto to reflect inner IP version")
> Reported-by: Artem Savkov <artem.savkov@...il.com>
> Tested-by: Artem Savkov <artem.savkov@...il.com>
> Signed-off-by: Yossi Kuperman <yossiku@...lanox.com>

Applied, thanks Yossi!