linux-kernel - Re: [PATCH v2 0/2] perf sched map: re-annotate shortname if thread comm changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180307022857.kqxmo24we5r54nlh@intel.com>
Date:   Wed, 7 Mar 2018 10:28:57 +0800
From:   "Du, Changbin" <changbin.du@...el.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...hat.com>, changbin.du@...el.com,
        peterz@...radead.org, mingo@...hat.com, namhyung@...nel.org,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 0/2] perf sched map: re-annotate shortname if thread
 comm changed

On Tue, Mar 06, 2018 at 11:17:07AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Mar 06, 2018 at 08:53:02AM +0100, Jiri Olsa escreveu:
> > On Tue, Mar 06, 2018 at 11:37:35AM +0800, changbin.du@...el.com wrote:
> > > From: Changbin Du <changbin.du@...el.com>
> > > 
> > > v2:
> > >   o add a patch to move thread::shortname to thread_runtime
> > >   o add function perf_sched__process_comm() to process PERF_RECORD_COMM event.
> > > 
> > > Changbin Du (2):
> > >   perf sched: move thread::shortname to thread_runtime
> > >   perf sched map: re-annotate shortname if thread comm changed
> > 
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> 
> Thanks, applied both, the final layout for 'struct thread_runtime':
> 
> [root@...et perf]# pahole -C thread_runtime ~/bin/perf
> struct thread_runtime {
> 	u64                        last_time;            /*     0     8 */
> 	u64                        dt_run;               /*     8     8 */
> 	u64                        dt_sleep;             /*    16     8 */
> 	u64                        dt_iowait;            /*    24     8 */
> 	u64                        dt_preempt;           /*    32     8 */
> 	u64                        dt_delay;             /*    40     8 */
> 	u64                        ready_to_run;         /*    48     8 */
> 	struct stats               run_stats;            /*    56    40 */
> 	/* --- cacheline 1 boundary (64 bytes) was 32 bytes ago --- */
> 	u64                        total_run_time;       /*    96     8 */
> 	u64                        total_sleep_time;     /*   104     8 */
> 	u64                        total_iowait_time;    /*   112     8 */
> 	u64                        total_preempt_time;   /*   120     8 */
> 	/* --- cacheline 2 boundary (128 bytes) --- */
> 	u64                        total_delay_time;     /*   128     8 */
> 	int                        last_state;           /*   136     4 */
> 	char                       shortname[3];         /*   140     3 */
> 	_Bool                      comm_changed;         /*   143     1 */
> 	u64                        migrations;           /*   144     8 */
> 
> 	/* size: 152, cachelines: 3, members: 17 */
> 	/* last cacheline: 24 bytes */
> };
> [root@...et perf]#

Hi Arnaldo, thanks for your patient optimization for this!

-- 
Thanks,
Changbin Du