linux-kernel - Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180307151831.u65fryr4e7mbdwpe@dell>
Date:   Wed, 7 Mar 2018 15:18:31 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     groeck@...omium.org, gwendal@...omium.org, bleung@...omium.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Vincent Palatin <vpalatin@...omium.org>
Subject: Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC

On Wed, 07 Mar 2018, Lee Jones wrote:

> On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote:
> 
> > From: Vincent Palatin <vpalatin@...omium.org>
> > 
> > If we cannot communicate with the EC chip to detect the protocol version
> > and its features, it's very likely useless to continue. Else we will
> > commit all kind of uninformed mistakes (using the wrong protocol, the
> > wrong buffer size, mixing the EC with other chips).
> > 
> > Signed-off-by: Vincent Palatin <vpalatin@...omium.org>
> > Acked-by: Benson Leung <bleung@...omium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > ---
> >  drivers/mfd/cros_ec.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Unless it is my mailer that is playing up, it looks as though you have
> sent this set un-threaded, which means that when others or myself
> start replying to them one-by-one, they will be sprawled throughout my
> inbox.  It also seems as though there is no 0th (cover letter) patch,
> which means I am lacking potentially important information regarding
> the history of the set and what you are trying to achieve.
> 
> Anyway, the patch has been applied this time (hopefully there aren't
> any inter-dependencies.

As discussed in 2/6, I'm going to un-apply this.

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog