linux-kernel - Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180307155353.rtpvuxnbu2oxioz2@dell>
Date:   Wed, 7 Mar 2018 15:53:53 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     groeck@...omium.org, andy.shevchenko@...il.com,
        kernel@...labora.com, gwendal@...omium.org,
        linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Olof Johansson <olof@...om.net>
Subject: Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

On Wed, 07 Mar 2018, Lee Jones wrote:

> On Mon, 26 Feb 2018, Enric Balletbo i Serra wrote:
> 
> > From: Douglas Anderson <dianders@...omium.org>
> > 
> > We should stop our worker thread while we're suspended.  If we don't
> > then we'll get messages like:
> > 
> >   cros-ec-spi spi5.0: spi transfer failed: -108
> >   cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108
> >   cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed
> > 
> > Signed-off-by: Douglas Anderson <dianders@...omium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> > ---
> > 
> > Changes in v3:
> > - [3/8] Add Reviewed-by Andy Shevchenko.
> > 
> > Changes in v2:
> > - [3/8] That patch is new in this series.
> > 
> >  drivers/mfd/cros_ec_dev.c                 |  4 ++++
> >  drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++
> >  include/linux/mfd/cros_ec.h               |  2 ++
> >  3 files changed, 26 insertions(+)
> 
> I plan to make this patch 1/X and send it out as a pull-request.
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>

In fact better still, could you do that and add a note below the ---
to that affect please?

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog