[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACPK8XevaaJSn2eZUt3dfAK+eOJ-hifnMqMme120jCRszpth1A@mail.gmail.com>
Date: Wed, 7 Mar 2018 14:26:06 +1030
From: Joel Stanley <joel@....id.au>
To: Haiyue Wang <haiyue.wang@...ux.intel.com>
Cc: Andrew Jeffery <andrew@...id.au>,
OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node
On Sun, Mar 4, 2018 at 3:33 PM, Haiyue Wang <haiyue.wang@...ux.intel.com> wrote:
> The IPMI KCS device part of the LPC interface and is used for
> communication with the host processor.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@...ux.intel.com>
> ---
> Hi Joel & Andrew,
>
> The kcs-bmc-aspeed module has been in:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/char/ipmi/kcs_bmc_aspeed.c
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
>
> I updated the device tree node about kcs-bmc, this is passed on my board.
>
> And the patch is generated by rebasing on:
> https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git
> Please help to review.
Thanks for the patch. I suggest you submit this patch for inclusion in
the upstream kernel. To do this, send it to:
Joel Stanley <joel@....id.au>
Andrew Jeffery <andrew@...id.au>
linux-arm-kernel@...ts.infradead.org
linux-aspeed@...ts.ozlabs.org
linux-kernel@...r.kernel.org
And I will consider it for merging.
>From there I can backport it into the dev-4.13 tree.
Cheers,
Joel
>
> BR,
> Haiyue
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 43 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 8eac57c..f443169 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -267,8 +267,40 @@
> ranges = <0x0 0x1e789000 0x1000>;
>
> lpc_bmc: lpc-bmc@0 {
> - compatible = "aspeed,ast2500-lpc-bmc";
> + compatible = "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
> reg = <0x0 0x80>;
> + reg-io-width = <4>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x80>;
> +
> + kcs1: kcs1@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <1>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs2: kcs2@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <2>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> + kcs3: kcs3@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0x80>;
> + interrupts = <8>;
> + kcs_chan = <3>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> };
>
> lpc_host: lpc-host@80 {
> @@ -294,6 +326,15 @@
> status = "disabled";
> };
>
> + kcs4: kcs4@0 {
> + compatible = "aspeed,ast2500-kcs-bmc";
> + reg = <0x0 0xa0>;
> + interrupts = <8>;
> + kcs_chan = <4>;
> + kcs_addr = <0x0>;
> + status = "disabled";
> + };
> +
> lhc: lhc@20 {
> compatible = "aspeed,ast2500-lhc";
> reg = <0x20 0x24 0x48 0x8>;
> --
> 2.7.4
>
Powered by blists - more mailing lists