linux-kernel - Re: [PATCH 1/3] certs: define a trusted platform keyring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31489.1520438598@warthog.procyon.org.uk>
Date:   Wed, 07 Mar 2018 16:03:18 +0000
From:   David Howells <dhowells@...hat.com>
To:     Nayna Jain <nayna@...ux.vnet.ibm.com>
Cc:     dhowells@...hat.com, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org
Subject: Re: [PATCH 1/3] certs: define a trusted platform keyring

Nayna Jain <nayna@...ux.vnet.ibm.com> wrote:

> +		key = key_create_or_update(make_key_ref(keyring, 1),
> +				"asymmetric",
> +				NULL,
> +				p,
> +				plen,
> +				((KEY_POS_ALL & ~KEY_POS_SETATTR) |
> +				 KEY_USR_VIEW | KEY_USR_READ),
> +				KEY_ALLOC_NOT_IN_QUOTA |
> +				KEY_ALLOC_BUILT_IN |
> +				KEY_ALLOC_BYPASS_RESTRICTION);

There's no need to reindent here.  Please line up all the arguments: either
push the first argument over onto the next line if you need to or line them
all up with the char after the opening bracket.

David