linux-kernel - Re: [PATCH v3 8/8] mfd: cros_ec_i2c: moving the system sleep pm ops to late

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180307160658.eezwydvv44oruw32@dell>
Date:   Wed, 7 Mar 2018 16:06:58 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     groeck@...omium.org, andy.shevchenko@...il.com,
        kernel@...labora.com, gwendal@...omium.org,
        linux-kernel@...r.kernel.org, Joseph Lo <josephl@...dia.com>
Subject: Re: [PATCH v3 8/8] mfd: cros_ec_i2c: moving the system sleep pm ops
 to late

On Mon, 26 Feb 2018, Enric Balletbo i Serra wrote:

> From: Joseph Lo <josephl@...dia.com>
> 
> The cros_ec_i2c driver is still active after it had suspended or before it
> resumes. Besides that, it also tried to transfer data even after the I2C
> host had been suspended. This will lead the system to crash.
> 
> During the test, we also observe that the EC needs to be resumed earlier
> due to some status polling from the EC FW (e.g. battery status). So we
> move the PM ops to late stage to make it work normally.
> 
> Signed-off-by: Joseph Lo <josephl@...dia.com>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
> 
> Changes in v3:
> - [8/8] Add static to cros_ec_i2c_pm_ops.
> - [8/8] Add the Reviewed-by Andy Shevchenko.
> 
> Changes in v2:
> - [8/8] This patch is new in this series replacing [5/6] of v1.
> 
>  drivers/mfd/cros_ec_i2c.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog