linux-kernel - [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180307162430.2664523-2-arnd@arndb.de>
Date:   Wed,  7 Mar 2018 17:24:13 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        linux-arm-kernel@...ts.infradead.org, openbmc@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

While looking at the build regression, I noticed that the
platform selects a lot of other Kconfig symbols that it really
should not:

CPU_V7, ARM_GIC, HAVE_SMP, COMMON_CLK, GENERIC_CLOCKEVENTS,
and CLKDEV_LOOKUP are all implied by ARCH_MULTI_V7, so they
can be dropped.

CACHE_L2X0, SMP and USB are meant to be user-selectable, we
want to be able to turn those off for testing purposes.

CPU_USE_DOMAINS looks completely misplaced here, we should not
select that for an ARMv7 platform.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 arch/arm/mach-npcm/Kconfig | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
index 2bc6697c8d97..c6a16230e8ef 100644
--- a/arch/arm/mach-npcm/Kconfig
+++ b/arch/arm/mach-npcm/Kconfig
@@ -12,12 +12,6 @@ comment "NPCM7XX CPU type"
 config ARCH_NPCM750
 	depends on ARCH_NPCM
 	bool "Support for NPCM750 BMC CPU (Poleg)"
-	select CACHE_L2X0
-	select CPU_V7
-	select ARM_GIC
-	select HAVE_SMP
-	select SMP
-	select SMP_ON_UP
 	select HAVE_ARM_SCU
 	select HAVE_ARM_TWD if SMP
 	select ARM_ERRATA_720789
@@ -26,18 +20,6 @@ config ARCH_NPCM750
 	select ARM_ERRATA_794072
 	select PL310_ERRATA_588369
 	select PL310_ERRATA_727915
-	select USB_EHCI_ROOT_HUB_TT
-	select USB_ARCH_HAS_HCD
-	select USB_ARCH_HAS_EHCI
-	select USB_EHCI_HCD
-	select USB_ARCH_HAS_OHCI
-	select USB_OHCI_HCD
-	select USB
-	select FIQ
-	select CPU_USE_DOMAINS
-	select GENERIC_CLOCKEVENTS
-	select CLKDEV_LOOKUP
-	select COMMON_CLK if OF
 	select NPCM750_TIMER
 	select MFD_SYSCON
 	help
-- 
2.9.0