linux-kernel - Re: [PATCH v2 2/6] dt-bindings: phy-rockchip-typec: move extcon property to be optional.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHNYxRx2kHvefaroNH_fhLcToXCH8q1TBfp-A8b0BNZ00jGL9w@mail.gmail.com>
Date:   Wed, 7 Mar 2018 11:42:00 -0800
From:   Alexandru Stan <amstan@...gle.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, Gwendal Grignou <gwendal@...omium.org>,
        Heiko Stuebner <heiko@...ech.de>, linux-kernel@...r.kernel.org,
        vicencb@...il.com, kishon@...com,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        groeck@...omium.org, kernel@...labora.com,
        linux-arm-kernel@...ts.infradead.org,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH v2 2/6] dt-bindings: phy-rockchip-typec: move extcon
 property to be optional.

On Wed, Mar 7, 2018 at 11:34 AM, Rob Herring <robh@...nel.org> wrote:
> On Thu, Mar 01, 2018 at 04:25:11PM +0100, Enric Balletbo i Serra wrote:
>> The extcon property is used to detect the cable-state but some boards
>> just connect the type-c phy to a regular USB-A connector without any
>> power-delivery and thus no controller reporting the cable-state.
>> So the extcon property is not really a required property, move it to be
>> optional instead.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
>> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
>> ---
>>
>> Changes in v2:
>> - [2/6] Rewrite the justification as suggested by Heiko Stuebner.
>>
>>  Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>
> And extcon should be deprecated IMO.
>
> Reviewed-by: Rob Herring <robh@...nel.org>

Hello Rob,

I'm currently learning a bit about USB and extcon.

Could you provide some background on why you think extcon should be
deprecated? What do you propose we replace it with?