linux-kernel - Re: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic pmu events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae102272a8186f0351363511f4ed07f8@codeaurora.org>
Date:   Thu, 08 Mar 2018 08:28:13 -0500
From:   Agustin Vega-Frias <agustinv@...eaurora.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>, timur@...eaurora.org
Subject: Re: [RFC V4] perf, tools: Support wildcards on pmu name in dynamic
 pmu events

On 2018-03-08 08:03, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 07, 2018 at 03:35:47PM -0500, Agustin Vega-Frias escreveu:
>> +++ b/tools/perf/util/parse-events.y
>> @@ -8,6 +8,7 @@
>> 
>>  #define YYDEBUG 1
>> 
>> +#include <fnmatch.h>
>>  #include <linux/compiler.h>
>>  #include <linux/list.h>
>>  #include <linux/types.h>
>> @@ -234,6 +235,10 @@ PE_NAME opt_event_config
>>  	if (parse_events_add_pmu(_parse_state, list, $1, $2)) {
>>  		struct perf_pmu *pmu = NULL;
>>  		int ok = 0;
>> +		char *pattern;
>> +
>> +		if (asprintf(&pattern, "%s*", $1) < 0)
>> +			YYABORT;
> 
> +               if (asprintf(&pattern, "?(uncore_)%s*", $1) < 0)
> 
> I completely overlook that you were using this and thus needed that
> extension, duh, thanks for the patience 8-) and for the new patch.
> 

NP Arnaldo, thanks for the quick turnaround on these patches :o)
Just so I know, since these are my first patches on perf tools,
where are perf tools patches queued once acked?

Thanks!

-- 
Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a 
Linux Foundation Collaborative Project.