linux-kernel - Re: [PATCH] usb: dwc2: Print error if unable to set DMA coherent mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1893294987.392820.1520530314966@email.1und1.de>
Date:   Thu, 8 Mar 2018 18:31:54 +0100 (CET)
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     John Youn <johnyoun@...opsys.com>, Felipe Balbi <balbi@...nel.org>
Cc:     Gevorg Sahakyan <gevorg.sahakyan@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Minas Harutyunyan <minas.harutyunyan@...opsys.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: dwc2: Print error if unable to set DMA coherent
 mask


> Stefan Wahren <stefan.wahren@...e.com> hat am 12. Februar 2018 um 21:20 geschrieben:
> 
> 
> We better print an error in case probing of dwc2 fails on
> setting the DMA coherent mask.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
> ---
>  drivers/usb/dwc2/platform.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
> index 4703478..4ddbdbd 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -382,8 +382,10 @@ static int dwc2_driver_probe(struct platform_device *dev)
>  	if (!dev->dev.dma_mask)
>  		dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
>  	retval = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
> -	if (retval)
> +	if (retval) {
> +		dev_err(&dev->dev, "can't set coherent DMA mask: %d\n", retval);
>  		return retval;
> +	}
>  
>  	res = platform_get_resource(dev, IORESOURCE_MEM, 0);
>  	hsotg->regs = devm_ioremap_resource(&dev->dev, res);
> -- 
> 2.7.4
>

ping ...