linux-kernel - Re: [PATCH AUTOSEL for 4.9 025/190] platform/x86: asus-nb-wmi: Add wapf4 quirk for the X302UA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180308173914.GC11045@localhost.localdomain>
Date:   Thu, 8 Mar 2018 09:39:14 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Sasha Levin <Alexander.Levin@...rosoft.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Santeri Toivonen <santeri.toivonen@...sul.com>
Subject: Re: [PATCH AUTOSEL for 4.9 025/190] platform/x86: asus-nb-wmi: Add
 wapf4 quirk for the X302UA

On Thu, Mar 08, 2018 at 04:59:01AM +0000, Sasha Levin wrote:
> From: Santeri Toivonen <santeri.toivonen@...sul.com>
> 
> [ Upstream commit f35823619db8bbaa2afea8705f239c3cecb9d22f ]
> 
> Asus laptop X302UA starts up with Wi-Fi disabled,
> without a way to enable it. Set wapf=4 to fix the problem.
> 
> Signed-off-by: Santeri Toivonen <santeri.toivonen@...sul.com>
> Signed-off-by: Darren Hart (VMware) <dvhart@...radead.org>
> Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>

Hi Sasha,

I'm curious about this AUTOSEL tag, and what about this patch triggered
its selection?

Pulling changes like this can be risky if they aren't done sequentially,
resulting in the stable driver having a spotty patching. I don't
necessarily object to *this* patch, but in general, I want to understand
what triggers the selection of patches that maintainers have not tagged
with stable and which do not contain fixes tags.

-- 
Darren Hart
VMware Open Source Technology Center