linux-kernel - Re: [RFC PATCH] usb: musb: Fix external abort in musb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180308182238.GI14921@uda0271908>
Date:   Thu, 8 Mar 2018 12:22:38 -0600
From:   Bin Liu <b-liu@...com>
To:     Merlijn Wajer <merlijn@...zup.org>
CC:     <ivo.g.dimitrov.75@...il.com>, <linux-omap@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] usb: musb: Fix external abort in musb_remove

On Thu, Mar 08, 2018 at 07:00:16PM +0100, Merlijn Wajer wrote:
> Hi,
> 
> On 08/03/18 17:46, Bin Liu wrote:
> 
> 
> > No need to flush, the work is already cancelled at this point.
> > 
> >> +
> >>  	musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> >> +	musb_platform_exit(musb);
> > 
> > This can be move down to out side of holding the spinlock,
> > 
> >>  	spin_unlock_irqrestore(&musb->lock, flags);
> > 
> > to here.
> 
> Thank you - with I've verified that it works with these changes. I'm
> surprised, because I believe that I had tried this already. I must have
> missed a step in my testing-routine.
> 
> I will send a patch shortly.

Thank you for fixing this up.

Regards,
-Bin.