[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180308204723.GA26248@lunn.ch>
Date: Thu, 8 Mar 2018 21:47:23 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Brad Mouring <brad.mouring@...com>
Cc: Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Subject: Re: [PATCH] net: phy: Tell caller result of phy_change()
> +++ b/drivers/net/phy/phy.c
> @@ -617,6 +617,8 @@ static void phy_error(struct phy_device *phydev)
> phy_trigger_machine(phydev, false);
> }
>
> +static irqreturn_t phy_change(struct phy_device *phydev);
> +
Hi Brad
Rather than add a forward declaration, please move phy_change().
Thanks
Andrew
Powered by blists - more mailing lists