linux-kernel - Re: [PATCH] usb: musb: Fix external abort in musb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d01c0eca-f14b-d888-e940-3c23bbfd701e@wizzup.org>
Date:   Thu, 8 Mar 2018 23:17:48 +0100
From:   Merlijn Wajer <merlijn@...zup.org>
To:     Bin Liu <b-liu@...com>, ivo.g.dimitrov.75@...il.com,
        linux-omap@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: musb: Fix external abort in musb_remove

Hi,

On 08/03/18 22:15, Bin Liu wrote:

> please add patch version numbers in the subject when necessary. This
> helps cross-referencing.

Will do. I naively assumed that the first patch would implicitly be
number 1. Will send out v2 now.

>>  
>> +	musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> 
> Does it solve the issue if not moving this line? I'd like to have
> minimum change if possible.

Yes, it does. The only reason I moved musb_writeb is because I
understood you wanted me to move both (per previous message: "This can
be move down to out side of holding the spinlock").

Thanks for the tips.

Cheers,
Merlijn



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)