linux-kernel - Re: [Xen-devel] [PATCH v2] xen/acpi: upload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f20689f-552f-b9eb-272d-0035ba2efdd6@oracle.com>
Date:   Thu, 8 Mar 2018 17:33:56 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Joao Martins <joao.m.martins@...cle.com>,
        linux-kernel@...r.kernel.org
Cc:     Juergen Gross <jgross@...e.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Robert Moore <robert.moore@...el.com>,
        linux-acpi@...r.kernel.org, xen-devel@...ts.xenproject.org,
        devel@...ica.org, Erik Schmauss <erik.schmauss@...el.com>,
        Len Brown <lenb@...nel.org>
Subject: Re: [Xen-devel] [PATCH v2] xen/acpi: upload _PSD info for non Dom0
 CPUs too



On 03/08/2018 05:57 AM, Joao Martins wrote:

> @@ -372,6 +376,15 @@ read_acpi_id(acpi_handle handle, u32 lvl, void *context, void **rv)
>   
>   	pr_debug("ACPI CPU%u w/ PBLK:0x%lx\n", acpi_id, (unsigned long)pblk);
>   
> +	/* It has P-state dependencies */
> +	if (!acpi_processor_get_psd(handle, &acpi_psd[acpi_id])) {
> +		__set_bit(acpi_id, acpi_id_psd_present);
> +
> +		pr_debug("ACPI CPU%u w/ PST:coord_type = %llu domain = %llu\n",
> +			 acpi_id, acpi_psd[acpi_id].coord_type,
> +			 acpi_psd[acpi_id].domain);
> +	}


I should have noticed this earlier, but do you really need 
acpi_id_psd_present? Can you just go by acpi_psd[i] != NULL?

Sorry for missing it in the first patch.

-boris