linux-kernel - Re: [PATCH 12/17] staging: lustre: remove unused flag from ptlrpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5E9E1F23-3BC8-4267-8B12-C1BBAF396F02@intel.com>
Date:   Thu, 8 Mar 2018 23:54:56 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     NeilBrown <neilb@...e.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        James Simmons <jsimmons@...radead.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 12/17] staging: lustre: remove unused flag from
 ptlrpc_thread

On Mar 1, 2018, at 16:31, NeilBrown <neilb@...e.com> wrote:
> 
> SVC_EVENT is no longer used.
> 
> Signed-off-by: NeilBrown <neilb@...e.com>

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lustre/include/lustre_net.h |   11 -----------
> 1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_net.h b/drivers/staging/lustre/lustre/include/lustre_net.h
> index 5a4434e7c85a..108683c54127 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_net.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_net.h
> @@ -1259,7 +1259,6 @@ enum {
> 	SVC_STOPPING    = 1 << 1,
> 	SVC_STARTING    = 1 << 2,
> 	SVC_RUNNING     = 1 << 3,
> -	SVC_EVENT       = 1 << 4,
> };
> 
> #define PTLRPC_THR_NAME_LEN		32
> @@ -1302,11 +1301,6 @@ struct ptlrpc_thread {
> 	char				t_name[PTLRPC_THR_NAME_LEN];
> };
> 
> -static inline int thread_is_init(struct ptlrpc_thread *thread)
> -{
> -	return thread->t_flags == 0;
> -}
> -
> static inline int thread_is_stopped(struct ptlrpc_thread *thread)
> {
> 	return !!(thread->t_flags & SVC_STOPPED);
> @@ -1327,11 +1321,6 @@ static inline int thread_is_running(struct ptlrpc_thread *thread)
> 	return !!(thread->t_flags & SVC_RUNNING);
> }
> 
> -static inline int thread_is_event(struct ptlrpc_thread *thread)
> -{
> -	return !!(thread->t_flags & SVC_EVENT);
> -}
> -
> static inline void thread_clear_flags(struct ptlrpc_thread *thread, __u32 flags)
> {
> 	thread->t_flags &= ~flags;
> 
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation