linux-kernel - [PATCH v2] ssb: use put_device() if device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1520485789-8550-1-git-send-email-arvind.yadav.cs@gmail.com>
Date:   Thu,  8 Mar 2018 10:39:49 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     m@...s.ch
Cc:     linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: [PATCH v2] ssb: use put_device() if device_register fail

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
changes in v2:
             Removed kfree() call for @dev.

 drivers/ssb/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 65420a9..a7a062b 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -521,8 +521,8 @@ static int ssb_devices_register(struct ssb_bus *bus)
 			ssb_err("Could not register %s\n", dev_name(dev));
 			/* Set dev to NULL to not unregister
 			 * dev on error unwinding. */
+			put_device(dev);
 			sdev->dev = NULL;
-			kfree(devwrap);
 			goto error;
 		}
 		dev_idx++;
-- 
1.9.1