linux-kernel - Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180308160650.6c62683e@canb.auug.org.au>
Date:   Thu, 8 Mar 2018 16:06:50 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>, broonie@...nel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-next@...r.kernel.org, mhocko@...e.cz,
        Shakeel Butt <shakeelb@...gle.com>
Subject: Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)

Hi Andrew,

On Wed, 7 Mar 2018 18:41:41 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Wed, 7 Mar 2018 18:20:12 -0800 Randy Dunlap <rdunlap@...radead.org> wrote:
> 
> > On 03/07/2018 04:20 PM, akpm@...ux-foundation.org wrote:  
> > > The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
> > > 
> > >    http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > mmotm-readme.txt says
> > > 
> > > README for mm-of-the-moment:
> > > 
> > > http://www.ozlabs.org/~akpm/mmotm/
> > > 
> > > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > > more than once a week.  
> > 
> > UML on i386 and/or x86_64:
> > 
> > defconfig, CONFIG_MEMCG is not set:
> > 
> > ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
> > ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
> >    css_put(&group->memcg->css);  
> 
> oops.
> 
> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
> 
> fix CONFIG_MEMCG=n build
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Amir Goldstein <amir73il@...il.com>
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: David Rientjes <rientjes@...gle.com>
> Cc: Greg Thelen <gthelen@...gle.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Joonsoo Kim <iamjoonsoo.kim@....com>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Michal Hocko <mhocko@...nel.org>
> Cc: Pekka Enberg <penberg@...nel.org>
> Cc: Shakeel Butt <shakeelb@...gle.com>
> Cc: Vladimir Davydov <vdavydov.dev@...il.com>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  fs/notify/group.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/notify/group.c~fs-fsnotify-account-fsnotify-metadata-to-kmemcg-fix
> +++ a/fs/notify/group.c
> @@ -38,7 +38,7 @@ static void fsnotify_final_destroy_group
>  		group->ops->free_group_priv(group);
>  
>  	if (group->memcg)
> -		css_put(&group->memcg->css);
> +		mem_cgroup_put(group->memcg);
>  
>  	kfree(group);
>  }

I have applied that to linux-next today.
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped