linux-kernel - Re: [PATCH v4 1/2] dt-bindings: add bindings doc for HiSilicon INNO USB2 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180308013208.GJ28619@dragon>
Date:   Thu, 8 Mar 2018 09:32:11 +0800
From:   Shawn Guo <shawn.guo@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Jianguo Sun <sunjianguo1@...wei.com>,
        Jiancheng Xue <xuejiancheng@...ilicon.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pengcheng Li <lpc.li@...ilicon.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: add bindings doc for HiSilicon INNO
 USB2 PHY

On Wed, Mar 07, 2018 at 03:11:18PM -0600, Rob Herring wrote:
> > +Example:
> > +
> > +perictrl: peripheral-controller@...0000 {
> > +	compatible = "hisilicon,hi3798cv200-perictrl", "syscon",
> > +		     "simple-mfd";
> 
> Is syscon needed here? Doesn't look like the phys need it.

For phys, "syscon" is not needed, but there are other devices to be
added which will need to access perictrl as syscon.  Anyway, I can drop
"syscon" from the example in this bindings doc to avoid the confusion.

> Is there no dependency on the peri ctrl probing first for the phys to 
> probe successfully? If there is some dependency, simple-mfd should not 
> be used.

No, there is no such dependency.  Right now the perictrl is there only
for populating the phy devcies.

> As for the phy binding,
> 
> Reviewed-by: Rob Herring <robh@...nel.org>

Thanks.

Shawn