[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180308072819.GA24090@himanshu-Vostro-3559>
Date: Thu, 8 Mar 2018 12:58:19 +0530
From: Himanshu Jha <himanshujha199640@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de,
pmeerw@...erw.net, gregkh@...uxfoundation.org,
linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, daniel.baluta@...il.com
Subject: Re: [PATCH 10/11] Staging: iio: accel: Add comments about units in
data read function
On Wed, Mar 07, 2018 at 08:50:30PM +0000, Jonathan Cameron wrote:
> On Mon, 5 Mar 2018 13:19:29 +0530
> Himanshu Jha <himanshujha199640@...il.com> wrote:
>
> > Clarify the conversion and formation of resultant data in the
> > adis16201_read_raw() with sufficient comments.
> >
> > Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
> This is fine but it needs to be in the original comment changing patch
> rather than removing the comments first then a few patches later putting
> back a different version.
>
> So good change but in the wrong place in the series. Learning to reorder
> a series and merge down multiple patches into one is very useful when
> working with git.
I will send v2 with all the updates!
What about sign_extend32 & reverse christmas ordering patch ? Will you
pick that up or shall I send them again ?
--
Thanks
Himanshu Jha
Powered by blists - more mailing lists