linux-kernel - Re: [PATCH 07/17] staging: lustre: ptlrpc: change GFP_NOFS to GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D522B515-A92B-4169-9B98-31F99ABF1D49@intel.com>
Date:   Thu, 8 Mar 2018 00:20:00 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     NeilBrown <neilb@...e.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        James Simmons <jsimmons@...radead.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 07/17] staging: lustre: ptlrpc: change GFP_NOFS to
 GFP_KERNEL

On Mar 1, 2018, at 16:31, NeilBrown <neilb@...e.com> wrote:
> 
> These allocations are performed during initialization,
> so they don't need GFP_NOFS.
> 
> Signed-off-by: NeilBrown <neilb@...e.com>

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c |    2 +-
> drivers/staging/lustre/lustre/ptlrpc/service.c  |    4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
> index 577c5822b823..625b9520d78f 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c
> @@ -377,7 +377,7 @@ static inline void enc_pools_alloc(void)
> 	page_pools.epp_pools =
> 		kvzalloc(page_pools.epp_max_pools *
> 				sizeof(*page_pools.epp_pools),
> -				GFP_NOFS);
> +				GFP_KERNEL);
> }
> 
> static inline void enc_pools_free(void)
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c b/drivers/staging/lustre/lustre/ptlrpc/service.c
> index 49417228b621..f37364e00dfe 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/service.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/service.c
> @@ -2046,7 +2046,7 @@ static int ptlrpc_main(void *arg)
> 			goto out;
> 	}
> 
> -	env = kzalloc(sizeof(*env), GFP_NOFS);
> +	env = kzalloc(sizeof(*env), GFP_KERNEL);
> 	if (!env) {
> 		rc = -ENOMEM;
> 		goto out_srv_fini;
> @@ -2072,7 +2072,7 @@ static int ptlrpc_main(void *arg)
> 	}
> 
> 	/* Alloc reply state structure for this one */
> -	rs = kvzalloc(svc->srv_max_reply_size, GFP_NOFS);
> +	rs = kvzalloc(svc->srv_max_reply_size, GFP_KERNEL);
> 	if (!rs) {
> 		rc = -ENOMEM;
> 		goto out_srv_fini;
> 
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation